search

DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.29k stars 154 forks source link

Add build instructions for Fedora. #725

Closed rl2939 closed 3 weeks ago

rl2939 commented 3 weeks ago

Is there anything else that needs to be done before this can be merged?

dromer commented 3 weeks ago

I haven't run Fedora in nearly a decade. Can you confirm 100% that these are all the required dependencies to do a full build? :)

rl2939 commented 3 weeks ago

I am able to build using vendored libraries. I am unable to build with system libraries (SYSDEPS=true), as the makefile says that "jansson dependency not installed/available. Stop.", despite jansson already being installed.

Should I remove the instructions for installing with system libraries for now?

dromer commented 3 weeks ago

You say the jansson dependency is already installed, but shouldn't the instructions explicitly install it? That should be the development headers aka jansson-devel (from what I can tell).

rl2939 commented 3 weeks ago

Adding jansson-devel does not change anything. 

$ make SYSDEPS=true
Makefile:53: *** jansson dependency not installed/available.  Stop.

Because I can't get it to work, should I remove the "Dependencies for using system libraries" section? There will only be a section for building with vendored libraries for Fedora if the system libraries section get removed.

dromer commented 3 weeks ago

@rl2939 hmm odd. but yeah if these instructions don't work then maybe better to omit them and only use the ones for the vendored libs.

rl2939 commented 3 weeks ago

Done.