search

DISTRHO / Cardinal

Virtual modular synthesizer plugin
https://cardinal.kx.studio/
GNU General Public License v3.0
2.29k stars 154 forks source link

Add SynthKit. #737

Open rl2939 opened 1 week ago

rl2939 commented 1 week ago

Adds the modules from SynthKit.

dromer commented 1 week ago

@rl2939 while we appreciate you adding modules to Cardinal we also need some good motivation to add more modules.

We are slowly reaching the limits of what we can feasibly add to the program. Partially because of what our automated builds can handle, but we also want to curate quality over quantity.

Please add some good motivation on why we should add certain modules and how they would enhance the project.

At the moment we want to focus on module updates (there are still plenty that need some attention) and bugfixes.

thnx!

dromer commented 1 week ago

For instance SynthKit provides basic logic modules that we already have from other modules in Cardinal.

So while they look nice and they can be added, what makes them stand out that warrants inclusion?

rl2939 commented 1 week ago

Please add some good motivation on why we should add certain modules and how they would enhance the project.

Thats fair. The reason I added this set of modules was because I wanted the two sequencers in the collection. Both sequencers have built in pitch quantization, and don't skip the first step on reset.

For instance SynthKit provides basic logic modules that we already have from other modules in Cardinal.

I'll see if I can pair the collection down so that the automated system builds just those two sequencers.

dromer commented 1 week ago

I didn't mean to selectively take modules from the specific plugin, but we really have to consider what we will add to Cardinal as a whole. We want to be able to maintain the project for a long time and having a reasonable size for both the CI and the User has to be considered with that :)