DISTRHO / DISTRHO-Ports

Linux audio plugins and LV2 ports
http://distrho.sourceforge.net/ports
249 stars 44 forks source link

Fixing an issue with running multiple custom build targets and meson. #102

Closed Gopall closed 6 months ago

Gopall commented 2 years ago

Hi.

I found an error when I attempted to compile one of the programs on windows.

As mentioned here ( https://mesonbuild.com/Custom-build-targets.html ), the Custom build targets in meson only allow you to run a single command.

So in the meson.build file in the ports subfolder, an error was occurring because of that. command: [ 'mkdir', '-p', plugin_lv2_dir, '&&', 'cd', plugin_lv2_dir, '&&', 'mv', plugin_lv2_lib.full_path(), plugin_lv2_dir / plugin_name + lib_suffix, '&&', (meson.is_cross_build() ? 'wine' : 'env'), lv2_ttl_generator, '.' / plugin_name + lib_suffix, ], instead of running the mkdir commands, then the cd and mv commands. it would only run the mkdir command and try to make the files that mv was supposed to move. This caused the build script to exit prematurely.

To fix this I made a barebones helper script. Meson will now pass the desired commands as arguments to the script. Then the script will run them. This fixed the compilation issue I had.

falkTX commented 6 months ago

This was fixed a similar way now