Vitalium: Notify host of changed parameters on patch load.

DISTRHO / DISTRHO-Ports

Linux audio plugins and LV2 ports

http://distrho.sourceforge.net/ports

249 stars 44 forks source link

Vitalium: Notify host of changed parameters on patch load. #131

Closed DarkRTA closed 2 months ago

DarkRTA commented 2 months ago

This fixes #96 as far as I am aware.

xard-dev commented 2 months ago

I tested the nightly build and can confirm that this pull request solved the issue #96 I was experiencing with various software with the LV2 version of Vitalium.

falkTX commented 2 months ago

logic looks good to me, but the syntax is very odd. please change

auto old_values = std::map<std::string, float>(); to just std::map<std::string, float> old_values;

and for (auto i = controls_.begin(); i != controls_.end(); i++) { to for (const auto& it : controls_) {

thanks!

DarkRTA commented 2 months ago

I am currently out on vacation and won't be able to fix this for a few days.

DarkRTA commented 2 months ago

this should be good now. found some downtime to go ahead and do this

falkTX commented 2 months ago

thanks! will merge now then