search

DISTRHO / DISTRHO-Ports

Linux audio plugins and LV2 ports
http://distrho.sourceforge.net/ports
252 stars 44 forks source link

Compile complains about the extra values to toggleOn/Off #36

Closed gitterdude closed 4 years ago

gitterdude commented 5 years ago

This is my very first PR, interaction with GitHub and an upstream project so bare with me. If this is the correct way to do these things I'll follow up with another 4 PRs

gitterdude commented 5 years ago

This fixes warnings ../source/OPLLookAndFeel.cpp:19:130: warning: right operand of comma operator has no effect [-Wunused-value] ../source/OPLLookAndFeel.cpp:20:127: warning: right operand of comma operator has no effect [-Wunused-value]

falkTX commented 4 years ago

I wonder if those values are meant to be inside the function... If they match, we can put them there. But then, upstream would have noticed that it does not look as expected. hmm, I am merging the removal, simpler that way :P