search

DISTRHO / DISTRHO-Ports

Linux audio plugins and LV2 ports
http://distrho.sourceforge.net/ports
261 stars 46 forks source link

Lines of code missing from oscillator_section.cpp #75

Closed tank-trax closed 3 years ago

tank-trax commented 3 years ago

while I was trying to figure out how to remove the authentication, text to wave and phone home features I started to poke around the changes you made and I noticed some lines of code missing from

interface/editor_sections/oscillator_section.cpp

around line 201

the missing lines to be re-added are....

  transpose_quantize_button_ = std::make_unique<TransposeQuantizeButton>();
  addOpenGlComponent(transpose_quantize_button_.get());
  transpose_quantize_button_->addQuantizeListener(this);

I thought this was problematic when I noticed it as I also saw that transpose_quantize_button_ was being called elsewhere...

I applied the changes you made in the "Patch code to remove login, download, auth, etc" commit 0453fa0 without adding those lines in and the VST3 and Standalone built but the Standalone had a segfault upon executing (did not try the VST3)

since this did not work I figured I'd try and added those lines in, rebuilt everything and the Standalone and VST3 both work now

here is an image with the VST3 in Bitwig with the Text to Waveform both removed from the menu but also removed from the back end as per your patches

image

tank-trax commented 3 years ago

closing this because I see the lines in there... mistake on my part