search

DISTRHO / DISTRHO-Ports

Linux audio plugins and LV2 ports
http://distrho.sourceforge.net/ports
261 stars 46 forks source link

Add port: SwankyAmp #78

Closed jpcima closed 3 years ago

jpcima commented 3 years ago

Hello, this adds SwankyAmp, a GPLv3 power amp simulator plugin. https://github.com/resonantdsp/SwankyAmp/

A small part of it depends on c++17 though, what's the policy towards that? Does it need rewriting in c++14 features?

falkTX commented 3 years ago

A small part of it depends on c++17 though, what's the policy towards that? Does it need rewriting in c++14 features?

Depends if we can make it work with the somewhat-old-but-not-that-much compilers. Seeing as this fails to build on macOS, I would say we need to rewrite/adapt to c++14 yes.

In file included from ../ports/swankyamp/source/PluginEditor.h:26:

../ports/swankyamp/source/PresetManager.h:22:10: fatal error: 'optional' file not found

#include <optional>

         ^~~~~~~~~~

1 warning and 1 error generated.
tank-trax commented 3 years ago

it builds on Buster using C++17

falkTX commented 3 years ago

Now builds, thanks! Looks good for a merge then.