search

DISTRHO / DPF-Plugins

Collection of DPF-based plugins for packaging
Other
101 stars 19 forks source link

Tons of Warnings from Namcap #7

Closed stefano-tronci closed 6 years ago

stefano-tronci commented 6 years ago

HI there! I am maintaining an Arch Linux PKGBUILD for this software on the AUR. I was going through my routine tests and I found that namcap produces many warnings that, to my understanding, are related to how the software is built. I though I would open an issue here. See below the namcap output:

dpf-plugins-git W: ELF file ('usr/lib/dssi/3BandEQ-dssi.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/3BandEQ-dssi/3BandEQ_ui') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/3BandSplitter-dssi.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/3BandSplitter-dssi/3BandSplitter_ui') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/AmplitudeImposer-dssi.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/AmplitudeImposer-dssi/AmplitudeImposer_ui') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/CycleShifter-dssi.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/CycleShifter-dssi/CycleShifter_ui') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/Kars-dssi.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/Kars-dssi/Kars_ui') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/MVerb-dssi.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/MVerb-dssi/MVerb_ui') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/Nekobi-dssi.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/Nekobi-dssi/Nekobi_ui') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/PingPongPan-dssi.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/PingPongPan-dssi/PingPongPan_ui') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/SoulForce-dssi.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/SoulForce-dssi/SoulForce_ui') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/3BandEQ-ladspa.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/3BandSplitter-ladspa.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/AmplitudeImposer-ladspa.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/CycleShifter-ladspa.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/MVerb-ladspa.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/MaBitcrush-ladspa.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/MaFreeverb-ladspa.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/MaGigaverb-ladspa.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/MaPitchshift-ladspa.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/PingPongPan-ladspa.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/SoulForce-ladspa.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/3BandEQ.lv2/3BandEQ_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/3BandEQ.lv2/3BandEQ_ui.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/3BandSplitter.lv2/3BandSplitter_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/3BandSplitter.lv2/3BandSplitter_ui.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/AmplitudeImposer.lv2/AmplitudeImposer_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/AmplitudeImposer.lv2/AmplitudeImposer_ui.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/CycleShifter.lv2/CycleShifter_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/CycleShifter.lv2/CycleShifter_ui.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/Kars.lv2/Kars_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/Kars.lv2/Kars_ui.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/MVerb.lv2/MVerb_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/MVerb.lv2/MVerb_ui.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/MaBitcrush.lv2/MaBitcrush_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/MaFreeverb.lv2/MaFreeverb_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/MaGigaverb.lv2/MaGigaverb_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/MaPitchshift.lv2/MaPitchshift_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/Nekobi.lv2/Nekobi_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/Nekobi.lv2/Nekobi_ui.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/PingPongPan.lv2/PingPongPan_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/PingPongPan.lv2/PingPongPan_ui.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/ProM.lv2/ProM.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/SoulForce.lv2/SoulForce_dsp.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/SoulForce.lv2/SoulForce_ui.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/lv2/glBars.lv2/glBars.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/3BandEQ-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/3BandSplitter-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/AmplitudeImposer-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/CycleShifter-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/Kars-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/MVerb-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/MaBitcrush-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/MaFreeverb-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/MaGigaverb-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/MaPitchshift-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/Nekobi-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/PingPongPan-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/ProM-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/SoulForce-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/vst/glBars-vst.so') lacks FULL RELRO, check LDFLAGS.
dpf-plugins-git W: ELF file ('usr/lib/dssi/3BandEQ-dssi.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/dssi/3BandSplitter-dssi.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/dssi/AmplitudeImposer-dssi.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/dssi/CycleShifter-dssi.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/dssi/Kars-dssi.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/dssi/MVerb-dssi.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/dssi/Nekobi-dssi.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/dssi/PingPongPan-dssi.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/dssi/SoulForce-dssi.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/3BandEQ-ladspa.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/3BandSplitter-ladspa.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/AmplitudeImposer-ladspa.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/CycleShifter-ladspa.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/MVerb-ladspa.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/MaBitcrush-ladspa.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/MaFreeverb-ladspa.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/MaGigaverb-ladspa.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/MaPitchshift-ladspa.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/PingPongPan-ladspa.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/ladspa/SoulForce-ladspa.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/3BandEQ.lv2/3BandEQ_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/3BandEQ.lv2/3BandEQ_ui.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/3BandSplitter.lv2/3BandSplitter_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/3BandSplitter.lv2/3BandSplitter_ui.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/AmplitudeImposer.lv2/AmplitudeImposer_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/AmplitudeImposer.lv2/AmplitudeImposer_ui.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/CycleShifter.lv2/CycleShifter_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/CycleShifter.lv2/CycleShifter_ui.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/Kars.lv2/Kars_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/Kars.lv2/Kars_ui.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/MVerb.lv2/MVerb_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/MVerb.lv2/MVerb_ui.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/MaBitcrush.lv2/MaBitcrush_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/MaFreeverb.lv2/MaFreeverb_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/MaGigaverb.lv2/MaGigaverb_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/MaPitchshift.lv2/MaPitchshift_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/Nekobi.lv2/Nekobi_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/Nekobi.lv2/Nekobi_ui.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/PingPongPan.lv2/PingPongPan_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/PingPongPan.lv2/PingPongPan_ui.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/ProM.lv2/ProM.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/SoulForce.lv2/SoulForce_dsp.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/SoulForce.lv2/SoulForce_ui.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/lv2/glBars.lv2/glBars.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/3BandEQ-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/3BandSplitter-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/AmplitudeImposer-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/CycleShifter-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/Kars-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/MVerb-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/MaBitcrush-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/MaFreeverb-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/MaGigaverb-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/MaPitchshift-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/Nekobi-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/PingPongPan-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/ProM-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/SoulForce-vst.so') lacks PIE.
dpf-plugins-git W: ELF file ('usr/lib/vst/glBars-vst.so') lacks PIE.
dpf-plugins-git W: Unused shared library '/usr/lib/libm.so.6' by file ('usr/lib/dssi/Kars-dssi/Kars_ui')
dpf-plugins-git W: Unused shared library '/usr/lib/libm.so.6' by file ('usr/lib/ladspa/MaBitcrush-ladspa.so')
dpf-plugins-git W: Unused shared library '/usr/lib/libm.so.6' by file ('usr/lib/ladspa/MaFreeverb-ladspa.so')
dpf-plugins-git W: Unused shared library '/usr/lib/libm.so.6' by file ('usr/lib/lv2/Kars.lv2/Kars_ui.so')
dpf-plugins-git W: Unused shared library '/usr/lib/libm.so.6' by file ('usr/lib/lv2/MaBitcrush.lv2/MaBitcrush_dsp.so')
dpf-plugins-git W: Unused shared library '/usr/lib/libm.so.6' by file ('usr/lib/lv2/MaFreeverb.lv2/MaFreeverb_dsp.so')
dpf-plugins-git W: Unused shared library '/usr/lib/libm.so.6' by file ('usr/lib/lv2/ProM.lv2/ProM.so')
dpf-plugins-git W: Unused shared library '/usr/lib/libm.so.6' by file ('usr/lib/vst/MaBitcrush-vst.so')
dpf-plugins-git W: Unused shared library '/usr/lib/libm.so.6' by file ('usr/lib/vst/MaFreeverb-vst.so')
dpf-plugins-git W: Unused shared library '/usr/lib/libm.so.6' by file ('usr/lib/vst/ProM-vst.so')
falkTX commented 6 years ago

does it set LDFLAGS correctly? If it is complaining about that, it might be a packaging issue.

falkTX commented 6 years ago

You can follow the makefiles to see LDFLAGS being respected. Building the 3BandEQ VST for example, comes from: https://github.com/DISTRHO/DPF-Plugins/blob/master/plugins/Makefile.Mini-Series.mk#L155 It uses LINK_FLAGS, which is defined here: https://github.com/DISTRHO/DPF-Plugins/blob/master/Makefile.mk#L67

So this would be a packaging issue on your side I guess..

stefano-tronci commented 6 years ago

Thank you for your help. Just before compilation, the value of LDFLAGS is that set in /etc/makepkg.conf:

-Wl,-O1,--sort-common,--as-needed,-z,relro

Do you think there is anything wrong that should be overridden by the PKGBUILD file?

falkTX commented 6 years ago

where does that warning come from? might be that you are overriding LDFLAGS yourself, and the package manager building process no longer passes what it wants, then it complains. I dont really know though, you have to figure out this yourself...

stefano-tronci commented 6 years ago

OK, thanks. To answer your question, I get the warnings when I check the built package with namcap. I think I will open a thread on Arch Linux forums, as I started having similar issues on other packages too.

stefano-tronci commented 6 years ago

Looks like half of those were an error in my system settings, the other half a false positive from namcap, More info here. Closing.