DISTRHO / DPF-Widgets

Official and Community made reusable GUI widgets for DPF
Other
25 stars 4 forks source link

Uhhyou.lv2 widgets? #2

Open mxmilkiib opened 3 years ago

mxmilkiib commented 3 years ago

https://github.com/ryukau/LV2Plugins/tree/master/common/gui

falkTX commented 3 years ago

These are GPL, so do not fit in the repo. Unless you convince the author to license those more liberally.

mxmilkiib commented 3 years ago

Ah right, yes. @ryukau might this be something you would be up for?

Edit: aside, re vst3, work has begun; https://github.com/DISTRHO/DPF/tree/travesty

ryukau commented 3 years ago

Hi.

First, I'm not interested in to spend my time to comply all the requirements of DPF-Widgets.

I'm OK with GPLv3/MIT dual license. I declare that anyone can use the code in this link under following license:

Copyright © 2021 Takamitsu Endo

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the “Software”), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

If anyone is planning to adapt the GUI widgets in my LV2Plugins repo, make sure to remove all the styling related code. This is because:

The styling is mostly for color configuration. In my opinion, it is necessary for accessibility.

falkTX commented 3 years ago

That is quite helpful, thank you.

For the PR you mean https://github.com/ryukau/LV2Plugins/pull/13 right?

@KottV what is your take on this?

falkTX commented 3 years ago

To be clear, I am not asking others to do anything, just want to clarify licensing terms.

KottV commented 3 years ago

Me? My "code" terms follows upstream. Is it ok?

falkTX commented 3 years ago

Yes you.

The situation here is that a few of us want to create a set of common widgets to use in all DPF related projects. As DPF is liberally licensed, it makes sense to make these widgets the same way.

@ryukau project is GPL though, so the changes you made end up GPL as well. You are the one to decide if you are okay with your code being used in other projects more liberally (that is, BSD/MIT license that allows commercial use).

KottV commented 3 years ago

I declare that anyone can use my contributed code to the https://github.com/ryukau/LV2Plugins/ project under the MIT license.

falkTX commented 3 years ago

Thank you

falkTX commented 1 year ago

Repo is gone, does anyone have a copy?

ryukau commented 1 year ago

Download link of the repository is available on this link.

mxmilkiib commented 1 year ago

To @ryukau - I would like to apologise for overstepping the line in my communications. I made multiple mistakes. I commented on a commit rather than opening an issue, I thought that would be less formal. I thought the filters repo was the most generic and active place to seek your opinion on the framework(s) you had implemented your DSP in. I was too hasty and earnest for your normative reflections on what put you off DPF beyond your technical notes and didn't show down to think about the pressure I was putting on you. I regret my actions, and my apologies again for the upset I have caused.

ryukau commented 1 year ago

@mxmilkiib I had prior experience of similar situation, where it ended really bad. That's why I reacted strongly.

To avoid misunderstanding, I have no hard feeling towards DPF. I also don't think VST 3 is the best or anything, but there's a fact that DPF nor even JUCE don't provide access to the complete features of underlying plugin format. I understand that it's a nature of framework that sometimes hides complexity and provides simpler interface, but that's the problem I have.

I will not engage further here, because it's off-topic.

dromer commented 1 year ago

Repo is gone, does anyone have a copy?

I have one here: https://github.com/Wasted-Audio/ryukau_LV2Plugins