search

DISTRHO / DPF-Widgets

Official and Community made reusable GUI widgets for DPF
Other
25 stars 4 forks source link

More imgui widgets #8

Open dromer opened 1 year ago

dromer commented 1 year ago

Thought to collect some possible imgui widgets here:

https://github.com/cmdwtf/imgui_toggle - nice looking toggle switches - 0BSD https://github.com/dalerank/imspinner - collection of animated spinner icons - MIT

dromer commented 1 year ago

Hmm, seems imgui_toggle breaks rules 1 and 6 since it contains more than one header and has several implementation files.

Unfortunate, since these do look quite nice.

dromer commented 1 year ago

Seems imspinner requires c++14 to work:

../../../dpf-widgets/opengl/DearImGuiSpinner/imspinner.h:150:24: error: use of ‘auto’ in lambda parameter declaration only available with ‘-std=c++14’ or ‘-std=gnu++14’
falkTX commented 1 year ago

This is not going to scale if we keep adding more widgets to imgui stuff. this toggle and knob are quite essential, so I let them pass, just dont assume it is always the case.

Regarding C++14 requirement, yeah it is preferred we keep it C++11 so the code needs tweaking. Other imgui based things are C++11, so let's not bump the requirement just for 1 single line of code.

dromer commented 1 year ago

Yeah agree, besides those spinners are not critical in any way just thought they looked cool ;)

Actually the imgui_toggle says it might be included in upstream imgui at some point: https://github.com/cmdwtf/imgui_toggle#future-considerations - will probably take a while, but by then we can clean it up from the inclusion perhaps.

falkTX commented 1 year ago

Personally think the spinners are quite optional and we dont need them by default.

Out of the other widgets I have seen, only the nodes one would be ideal to have, but it needs some tweaking to work well for audio graph/patchbay purposes.

We can always manually include imgui based widgets on plugin gui code, alike done in master_me with the implot, see https://github.com/trummerschlunk/master_me/blob/master/plugin/widgets/Histogram.hpp

dromer commented 1 year ago

re node editor, which of these do you think is better?

Very much leaning towards the second one.

Any other DPF patching plugin ideas floating already?

dromer commented 3 months ago

We were discussing sending midi notes from the UI and I came across: https://github.com/shric/midi/blob/master/src/Piano.cpp