Closed dromer closed 1 year ago
Seems good to me, only part missing is a license file because the code does not include any comment header to specify it.
Actually, please take the chance and do the same for imgui knobs.
The others have licenses, these should too. See https://github.com/DISTRHO/DPF-Widgets/blob/main/opengl/DearImGuiColorTextEditor/LICENSE and https://github.com/DISTRHO/DPF-Widgets/blob/main/opengl/DearImGui/LICENSE.txt
Yes yes, I went off how imgui_knobs did it, although they don't have a license header. Will add it.
Added the missing LICENSE file for DearImGuiKnobs as well (would be appropriate right)
Seems good to me, anything you still want to do on your side?
Unless you want some other confirmation that it works as expected it's good I think.
Eventually we need some plugin or application that puts these to test, but it is still kinda early days for dpf+imgui so for now it is fine. Will merge now, thanks!
@falkTX like this? :D
Works on a simple test plugin I made: