search

DISTRHO / DPF

DISTRHO Plugin Framework
ISC License
663 stars 95 forks source link

Fail to use requestParameterValueChange() on host which support it #435

Closed brummer10 closed 1 year ago

brummer10 commented 1 year ago

branch pugl-update-v4

It seems #define DISTRHO_PLUGIN_WANT_PARAMETER_VALUE_CHANGE_REQUEST 1 have no effect. Parameters wont be updated in the UI. This is on the MOD which usually supports this feature. I could use it when implement it directly in a LV2 wrapper, still, when using it within DPF it refuse to work. Related plug source code is here: https://github.com/brummer10/neuralrecord maybe I do something wrong?

falkTX commented 1 year ago

you are requesting a parameter change right? there is a specific call for this

falkTX commented 1 year ago

https://github.com/DISTRHO/DPF/blob/main/distrho/DistrhoInfo.hpp#L569 mentions what to do

brummer10 commented 1 year ago

Yep, I've done that: https://github.com/brummer10/neuralrecord/blob/main/plugins/NeuralRecord/DistrhoPluginInfo.h#L29

I hand over the requestParameterValueChange() call to the dsp class here: https://github.com/brummer10/neuralrecord/blob/main/plugins/NeuralRecord/PluginNeuralCapture.cpp#L21

take it here: https://github.com/brummer10/neuralrecord/blob/main/plugins/NeuralRecord/profiler.cc#L211 on a std::function call https://github.com/brummer10/neuralrecord/blob/main/plugins/NeuralRecord/profiler.h#L150 and use it like this: https://github.com/brummer10/neuralrecord/blob/main/plugins/NeuralRecord/profiler.cc#L546

brummer10 commented 1 year ago

Latest commits to the repository fixed this issue. Thanks a lot. So we could close this now.