search

DISTRHO / PawPaw

Cross-Platform build scripts for audio plugins
ISC License
63 stars 9 forks source link

pack-jack2.sh: add microphone permissions entry #10

Closed dyfer closed 3 years ago

dyfer commented 3 years ago

This is an attempt to add appropriate Info.plist entry to enable microphone permissions on macOS for QJackCtl. The added sed code was tested on the Info.plist from the shipped version of QJackCtl app bundle from jack 1.9.16 and results in the following contents:

```xml NSPrincipalClass NSApplication CFBundleIconFile CFBundlePackageType APPL CFBundleGetInfoString Created by Qt/QMake CFBundleSignature ???? CFBundleExecutable qjackctl CFBundleIdentifier com.yourcompany.qjackctl NOTE This file was generated by Qt/QMake. NSMicrophoneUsageDescription Jack wants to use your microphone or sound input ```

I didn't test this as part of the script in this repo, sorry...

Should fix https://github.com/jackaudio/jack2/issues/724

falkTX commented 3 years ago

let me trigger a new build on jack2-releases repo to test for this.

falkTX commented 3 years ago

that is failing.

sed: 1: "/\/dict/i \\t\<key\>NSM ...": extra characters after \ at the end of i command

is the regex bsd sed compatible? did you try it on a macOS machine as-is?

dyfer commented 3 years ago

is the regex bsd sed compatible? did you try it on a macOS machine as-is?

Actually, not! I had problem with macOS sed and I though that you're using GNU sed, my bad. I'll try to fix this.

dyfer commented 3 years ago

I think it should work now... could you trigger a build to try it?

dyfer commented 3 years ago

@falkTX did you have a chance to test this?

falkTX commented 3 years ago

Sorry for late response on this, was not really comfortable with the sed syntax. The generated file still has 1 unused/useless note regarding Qt, so I went ahead patched against that, done in 99cb44757cbbc70e02e99221bcd30111168e9d3e Thanks anyway