search

DISTRHO / PawPaw

Cross-Platform build scripts for audio plugins
ISC License
63 stars 8 forks source link

qjackctl: build using cmake as autotools is deprecated by upstream #20

Closed amurzeau closed 2 years ago

amurzeau commented 2 years ago

Autotools is not supported anymore by upstream qjackctl but just kept as-is. CMake is now its main build system (and is the only accepting PRs to support fixes for detecting jack features).

This allows correctly detecting jack features like metadata. Also drop the patch as qjackctl cmake build system takes care of the required macro.

Also use new MacOS package procedure which include Info.plist and icons without needing to add them manually.

I've tested built artifact on Windows and MacOS Big Sur using built artifacts from github actions here: https://github.com/amurzeau/PawPaw/actions/runs/1309141029 (I've added the release.yml from jack2-release to test them from PawPaw repo)

This fixes https://github.com/jackaudio/jack2/issues/783

falkTX commented 2 years ago

This is very nice, thanks a lot!

I see a few issues though, will comment on them individually.