search

DIVA-DIA / DeepDIVA

⛔️ DEPRECATED <Python Framework for Reproducible Deep Learning Experiments>
https://diva-dia.github.io/DeepDIVAweb
GNU Lesser General Public License v3.0
32 stars 31 forks source link

Update triplets after regeneration #15

Closed ashlaban closed 5 years ago

ashlaban commented 5 years ago

I suspect that, while triplets are regenerated here, they are not updated in the dataset. Looking at how this case is handled initially https://github.com/DIVA-DIA/DeepDIVA/blob/4dccf3b5fab5d45abd09977f37079f1803520988/datasets/image_folder_triplet.py#L138 and at the function generate_triplets https://github.com/DIVA-DIA/DeepDIVA/blob/4dccf3b5fab5d45abd09977f37079f1803520988/datasets/image_folder_triplet.py#L145 we see that this function only creates a new set, it never assigns to self.triplets.

Another idea would be to change the semantics of generate_triplets to modify the underlying instance (or create a helper regenerate_triplets for this purpose).