DIY-Machines / DigitalClockSmartShelving

A 3D printable shelving system with a hidden giant clock in its shelves edges
97 stars 73 forks source link

Extraction of “smoothiner” logic and other clean ups #2

Closed LupusMichaelis closed 4 years ago

LupusMichaelis commented 4 years ago

Hi,

I did some improvements on the code, as I spotted some potential issues (int too narrows for the data handled).

Although, there is some magic numbers I don't know what they correspond too exactly (the position on the LED strips?). It would help to make constants of them, or adding a comment/schema to show the path.

I don't have the hardware to run the software, so all I did is compiling and uploading to my Arduino (which is a mega-like). So, I'd like to know if those modifications introduced bugs or improved it as I expected.

Thanks for the code, the project and the video!