DJ2LS / FreeDATA

A free, open-source, multi-platform application for sending files and messages, using the codec2 HF modems
https://wiki.freedata.app/
GNU General Public License v3.0
143 stars 18 forks source link

[Bug]: ping ACK contains no callsign #729

Closed dk5sm closed 1 week ago

dk5sm commented 4 months ago

FreeDATA Version

current dev version (0.15.9-alpha)

What operating system are you using?

Ubuntu

Operating System Version

22.04

Architecture

x86

Area of problem

Server - Message System

Describe the bug

image

2024-05-21 11:23:08 [debug ] Event: ev={'type': 'frame-handler', 'received': 'PING_ACK', 'timestamp': 1716283388, 'mycallsign': 'DK5SM', 'myssid': 1, 'snr': '-5', 'dxcallsign': None, 'gridsquare': 'JN48EA', 'distance_kilometers': 366.5984079156632, 'distance_miles': 227.79361932496354}

A ping to a dedicated station returns with dxcallsign = None instead of reporting the IRS cs.

To Reproduce

-> Ping

Expected behavior

ACK should contain IRS' callsign.

Screenshots

No response

Log Files

No response

Additional context

No response

DJ2LS commented 2 months ago

Todo: None is returned if the checksum isnt in callsign database, therefore we have to check if it is existing, if not, do it

DJ2LS commented 2 weeks ago

fixed :-)

DJ2LS commented 2 weeks ago

We should save the ping and QRM related data as well

DJ2LS commented 1 week ago

What's the state of this one, @dk5sm , did we fix it?

dk5sm commented 1 week ago

Uuh, sorry for missing feedback. I guess this must have been solved a while ago, as I haven't noticed it for a long time. -> Close.

LA3QMA commented 1 week ago

Just discovered this today

2024-09-21 15:19:27 [debug ] Event: ev={'type': 'frame-handler', 'received': 'QRV', 'timestamp': 1726924767, 'mycallsign': 'LA3QMA', 'myssid': 1, 'snr': '0', 'dxcallsign': 'OH3UQ-1', 'gridsquare': 'KP20SX', 'distance_kilometers': 1093.4742138029906, 'distance_miles': 679.453165704978} 2024-09-21 15:19:33 [debug ] Event: ev={'type': 'frame-handler', 'received': 'QRV', 'timestamp': 1726924773, 'mycallsign': 'LA3QMA', 'myssid': 1, 'snr': '-7', 'dxcallsign': 'OH3UQ-1', 'gridsquare': 'KP20SX', 'distance_kilometers': 1093.4742138029906, 'distance_miles': 679.453165704978} 2024-09-21 15:38:59 [debug ] Event: ev={'type': 'frame-handler', 'received': 'PING_ACK', 'timestamp': 1726925939, 'mycallsign': 'LA3QMA', 'myssid': 1, 'snr': '1', 'dxcallsign': None, 'gridsquare': 'KP20SX', 'distance_kilometers': 1093.4742138029906, 'distance_miles': 679.453165704978} 2024-09-21 15:42:38 [debug ] Event: ev={'type': 'frame-handler', 'received': 'PING_ACK', 'timestamp': 1726926158, 'mycallsign': 'LA3QMA', 'myssid': 1, 'snr': '0', 'dxcallsign': None, 'gridsquare': 'KP20SX', 'distance_kilometers': 1093.4742138029906, 'distance_miles': 679.453165704978} 2024-09-21 15:44:46 [debug ] Event: ev={'type': 'frame-handler', 'received': 'QRV', 'timestamp': 1726926286, 'mycallsign': 'LA3QMA', 'myssid': 1, 'snr': '3', 'dxcallsign': 'OH3UQ-1', 'gridsquare': 'KP20SX', 'distance_kilometers': 1093.4742138029906, 'distance_miles': 679.453165704978} Screenshot from 2024-09-21 16-13-13