search

DJATOM / x265-aMod

DJATOM's mod for x265 encoder
GNU General Public License v2.0
84 stars 10 forks source link

Compiling Error with Visual Studio #18

Closed Patman86 closed 2 years ago

Patman86 commented 2 years ago

After adding the new AQ mode, compiling with Visual Studio ends with error 'c1061 compiler limit blocks nested too deeply'. With GCC there is no problem compiling. param.cpp cause the problem.

DJATOM commented 2 years ago

I can't look into it for now (I'm in Ukraine). Maybe @noizuy can check...

Patman86 commented 2 years ago

oh yes, i forgot, sorry. I hope this shit ends soon, hold on!

DJATOM commented 2 years ago

Commit 7b509d3 probably fixes that problem. According to stackoverflow, we reached a compiler limit on nested conditions (it must be 127 or less), so adding new options breaks MSVC support. It might be avoided with lists, but I don't feel brave enough to rewrite that code.

Patman86 commented 2 years ago

I saw that on stack overflow too. I'll test it and give you a feedback.

Patman86 commented 2 years ago

Your changes work, but are not necessary. Just paste the OPT("aq-bias-strength") into the space below this IF statement. Someone has already thought of something, see here 😜🤣

DJATOM commented 2 years ago

Doh, I have to retract the change =_=

DJATOM commented 2 years ago

Now it properly fixed.