search

DJATOM / x265-aMod

DJATOM's mod for x265 encoder
GNU General Public License v2.0
86 stars 10 forks source link

fps display in the progress text should better be instant ? #9

Open ghost opened 3 years ago

ghost commented 3 years ago

Hello @DJATOM !

Currently the progress text of x265 shows important information, all calculated properly, but it seems that fps is calculated as average from the beginning:

fps = (nb of frames processed since beginning) / (time elapsed since beginning).

This gives a idea of the global behavior in the process.

However, fps is a bench-marking information. It has to reflect current status of processing speed. Let's say, there is suddenly another process launched on the computer, then the fps should almost immediately drop. But it doesn't because the fps is a long term average here. So, I suggest:

fps = (nb of frames processed on a sliding window, or in a buffer) / (time used to process those frames)

That of course, is in my humble opinion. And thanks always for the great work!

DJATOM commented 3 years ago

I personally think that average fps is more meaningful then instant. But sure, I'll consider it and probably make an option to calculate fps with different strategies.

ghost commented 3 years ago

I totally agree that all fps methods have uses and pros and cons indeed. Thanks for anything you would do 😄 ! The Kbps meter seems also global... Well maybe, it's about "instant statistics" and "global statistics" and not only fps. Just a thought...

Dendraspis commented 3 years ago

Just an idea: The current fps would not be very useful, because it might jump a lot. But instead an additional 5min average could be nice/interesting. 🤔

ghost commented 3 years ago

@Dendraspis agreed, "pure" instant values have no use at all ! Also @DJATOM suggested that the "range" used to calculate the average can be set by the user. Personnaly I'd use a buffer of 200 or 300 frames...

However, the Total Size andTime Remaining should always use the global average values (exactly as they are currently calculated) otherwise they would be unreliable. On second thought, this is not so obvious 🤣

ghost commented 3 years ago

I have added an element of information here: https://github.com/Patman86/x265-Mod-by-Patman/issues/4

Hopefully, "someone" will take a look at it 😁

DJATOM commented 3 years ago

Unfortunately I don't have much time to look into that feature in few weeks or so, as I've got a load of work 😞