CSS Stylings possibly break when used with Bootstrap/AdminLTE

DJBarnes / django-dump-die

Django App providing a mechanism for extracting the details of any python variable and dumping it to the browser.

https://django-dump-die.readthedocs.io/

MIT License

8 stars 0 forks source link

CSS Stylings possibly break when used with Bootstrap/AdminLTE #19

Open brodriguez8774 opened 2 years ago

brodriguez8774 commented 2 years ago

Needs verification on other machines and/or in additional projects.

DJBarnes commented 2 years ago

I'd have to check it out myself. I don't see how. The dump screen does not extend from any other templates. This means that the CSS and JS that are loaded should only be what is needed for dumping. Nothing else. So, I don't see how it could conflict.

Unless you are using the template tag. In which case the documentation has a warning that it will collide with the CSS of your site and lead to really weird formatting. It also mentions that the majority of dumping should be done via python code and not the template. The template tag is a "use at your own risk" type of tag.

brodriguez8774 commented 2 years ago

I know we verbally discussed this, but just writing it here so it's not forgotten:

This problem only came up once, on a specific machine. If we're unable to replicate this, it's possible that it was something improperly set up on the local machine. Both the django-dump-die and django-adminlte2 packages have also been updated since, so it's possible it was somehow unintentionally resolved from that.

Either way, it seems this is not (currently) a thing that seems easily reproducible. But I vote this issue stays open until both packages are in a more "final" state, at which point we can test again on a few machines (hopefully including the original machine) and see if it can be reproduced at all.

brodriguez8774 commented 2 years ago

Have we been able to (or even attempted to) reproduce this since it was last comment? To my knowledge, we have not tried. But probably should, particularly now that both packages are presumably stable, since they're public at this point.