search

DJDavid98 / BSDataPuller

Gathers data about the current map you are playing to then be sent out over a websocket for other software to use, e.g. A web overlay like BSDP-Overlay. This mod works with multi PC setups!
https://github.com/ReadieFur/BeatSaber-Overlay
GNU General Public License v3.0
3 stars 1 forks source link

Score Mismatch #7

Open Azshurith opened 1 month ago

Azshurith commented 1 month ago

The score in my overlay did not match in game

https://www.youtube.com/watch?v=_7gcZh4EMo8

This is the mod I'm using

https://github.com/Kylon99/AlternativePlay/tree/master/AlternativePlay

DJDavid98 commented 1 month ago

I do not see anything obvious from the code of these two mods that could be causing the score mismatch. I know for a fact that DataPuller calculates the score on its own from the GoodCutScoringElement when the BeatmapObjectExecutionRatingsRecorder.HandleScoringForNoteDidFinish method is called, so as far as I can tell AlternativePlay is modifying things without updating what is sent in that call, hence the score mismatch. Personally I don't consider this a bug in this mod, nor do I have the know-how on how to work around this. I'm not the original author, I'm simply maintaining this mod and adding things that I need for myself. The only suggestion I can give is to hide the score from the overlay when playing in these modes.

Azshurith commented 1 month ago

Ahh, sorry for being wrong.

image

I had no bombs and no walls enabled which causes the score to mismatch from the data puller.

I disabled both settings and the score did match.

image

Will you fix this calculation issue with the vanilla modifiers?

This clip shows that the score is in sync however I am a Darth Maul player and is suffering from bombs

https://youtu.be/g5iy8a1POZQ?t=161

DJDavid98 commented 1 month ago

The author of AlternativePlay confirmed that mod does not mess with scores so in theory DataPuller is currently counting these wrong regardless of whether the mod is installed. I will need to have a closer look.