DJDavid98 / bsrpc

Discord Rich Presence support for Beat Saber, now with 100% more configurability!
MIT License
14 stars 4 forks source link

DiscordCore breaks on 1.31.1 #8

Closed AltEvolutions closed 11 months ago

AltEvolutions commented 11 months ago

Ended up updating to a more recent version of BS (specifically 1.31.1 due to all the other mods I use being available for that version) and while the main bsrpc plugin manages to load in, as well as all the correct versions of the other dependencies, DiscordCore seems to break according to my _latest.log

[WARNING @ 21:23:43 | IPA/Loader] Mod DiscordCore developed for game version 1.29.1, so it may not work properly.
[NOTICE @ 21:23:43 | IPA/Loader] Plugin DiscordCore has no methods marked [OnStart] or [OnEnable]. Is this intentional?
[NOTICE @ 21:23:43 | IPA/Loader] Plugin DiscordCore has no methods marked [OnExit] or [OnDisable]. Is this intentional?
[ERROR @ 21:23:43 | IPA/Loader] Could not init plugin DiscordCore
[ERROR @ 21:23:43 | IPA/Loader] System.TypeLoadException: Could not resolve type with token 0100002a from typeref (expected class 'PersistentSingleton`1' in assembly 'HMLib, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null')
[ERROR @ 21:23:43 | IPA/Loader]   at (wrapper dynamic-method) System.Object.lambda_method(System.Runtime.CompilerServices.Closure,IPA.Loader.PluginMetadata)
[ERROR @ 21:23:43 | IPA/Loader]   at IPA.Loader.PluginExecutor.Create () [0x00009] in D:\a\BeatSaber-IPA-Reloaded\BeatSaber-IPA-Reloaded\IPA.Loader\Loader\PluginExecutor.cs:58 
[ERROR @ 21:23:43 | IPA/Loader]   at IPA.Loader.PluginLoader.InitPlugin (IPA.Loader.PluginMetadata meta, System.Collections.Generic.IEnumerable`1[T] alreadyLoaded) [0x001ab] in D:\a\BeatSaber-IPA-Reloaded\BeatSaber-IPA-Reloaded\IPA.Loader\Loader\PluginLoader.cs:959 

Personally, I can jump between my original install and my latest one for the time being, so there's no rush to update it. Especially if it requires a bit of a rewrite but I wanted to mention it anyway

DJDavid98 commented 11 months ago

I added issues to my forked repository for DiscordCore, let's move the discussion there