DJDoubleD / QobuzDownloaderX-MOD

Downloads streams directly from Qobuz. Experimental refactoring of QobuzDownloaderX by AiiR
GNU General Public License v3.0
530 stars 17 forks source link

An unnecessary zero. #7

Closed IgorO25 closed 1 year ago

IgorO25 commented 1 year ago

An unnecessary zero. Is it possible not to add an unnecessary zero in the tags of the track number? Was: "01", "02", etc., should be "1", "2", etc.

IgorO25 commented 1 year ago

Initially and in previous versions of the program, this zero was not.

DJDoubleD commented 1 year ago

I looked into this, and it's a result of an update in the taglib-sharp library that is used for file tagging. When I created my fork, I updated the dependencies and this seems to be one of the changes in the most recent update TaglibSharp-2.3.0.0 where they state in this issue that a a two-digit zero-filled value is the expected formatting of the track number tag. They state that this formatting solves track sorting issues is some music players but I think most modern music players can handle both "01" and "1" as track number. @IgorO25 Does this really cause problems in any software? Or is it more an OCD kind of thing ;-) If it's just a preference thing, I prefer to stick to the standard of the tagging library as they did claim to have fixed some bugs in they latest releases.

IgorO25 commented 1 year ago

These are my preferences. Because of this, I unfortunately do not use your wonderful product, because there is additional work to remove zeros.

DJDoubleD commented 1 year ago

Since I did explicitly put "Experimental" in the project description and I personally also do prefer the clean numerical track numbering in the track metadata, I decided to implement the change and we'll just see what happens...