search

DJDoubleD / refreezer

An alternative Deezer music streaming & downloading client, based on Freezer.
GNU General Public License v3.0
285 stars 9 forks source link

[Bug] Lyrics Button Active in Landscape Mode for Tracks with No Lyrics #19

Closed justpanchi closed 2 months ago

justpanchi commented 2 months ago

🐞 Bug Report

Describe the bug

In the music player screen, when a track has no lyrics, the lyrics button is usually greyed out and unresponsive. However, when the device is rotated to landscape mode, the button becomes active and can be pressed, resulting in an empty lyrics screen being displayed.

Is this a regression?

No, this bug has been present in previous versions of the app, but it was only noticed recently.

To Reproduce

  1. Open the music player app.
  2. Select a track that does not have lyrics.
  3. Ensure the device is in portrait mode; verify that the lyrics button is greyed out.
  4. Rotate the device to landscape mode.
  5. Press the now-active lyrics button.
  6. Observe that an empty lyrics screen is displayed.

Expected behaviour

The lyrics button should remain greyed out and unresponsive when there are no lyrics available, regardless of the device orientation.

Screenshots

Portrait Landscape Landscape_Lyrics

Additional context

This issue appears to be related to how the app handles orientation changes and the availability of lyrics.

DJDoubleD commented 2 months ago

Oops, forgot to use the lyrics button widget in the horizontal view...