search

DJDoubleD / refreezer

An alternative Deezer music streaming & downloading client, based on Freezer.
GNU General Public License v3.0
276 stars 10 forks source link

MOD / Collaboration #39

Closed PetitPrinc3 closed 2 weeks ago

PetitPrinc3 commented 2 weeks ago

This is my MOD based on your app. My goal is to get closer to the official Deezer app. It is not final, as some things are not yet fully implemented. Feel free to either include it in another branch of your project, or discard it if it doesn't meet your expectations.

Cheers !

DJDoubleD commented 2 weeks ago

Hi

I haven't yet had the chance to test or look through all the changes you made, but based of your screenshots, it looks very good. While I'm personally not a huge fan of the rebrand Deezer did, I'm still interested in exploring different UI options.

I'm not going to completely change ReFreezer to Deezer like you did (I'm going to keep the ReFreezer "brand" & identity), so I can't really merge your changes "as is" into my master branch.

I do want to explore your changes more and see if it might be possible to scope your changes into a theme that the user can select. This would give them the option to switch between the classic UI and the new UI. At this moment I'm not sure this is possible but it feels like it should be if all the currently hard coded UI elements in certain widgets would be made dynamic so they are rendered according to the selected theme. I also tried to keep the ReFreezer UI accessible on all devices (phone, tablet, TV) in both portrait and landscape orientation. So that is something to keep in mind.

At this point, I've created a separate branch deezer_ui, as you suggested, and changed this PR to target that branch. I'll merge your changes into that branch, so I can explore it more (I cannot guarantee I'll find the needed time work on the project more, though). Feel free to target that branch if you feel like sharing more changes.

Should you also be interested in exploring the idea of having the choice between the classic UI and your new UI as a theme choice, that would be great as it would then at 1 point be possible to include most of your changes into the main ReFreezer app as well.

PetitPrinc3 commented 2 weeks ago

Thank you for your reply and interest.

Most of the changes could be made dynamic I guess, apart for a few maybe (floating player bar for example). I'll definitely try to turn the changes into a theme choice once I'm happy with all the features.

I am currently working on the different screens (favorite, explore, ...) and I will make sure to keep you up to date with my progress.

Feel free to contact me on discord or by email so we can discuss more freely maybe !

Discord : @petitprinc3