Closed darkksuns closed 4 months ago
This is great, seems like a clean modal window with a modern feel with the open/close animations. One thing we could think about adding is keyboard interactivity, like being able to close the window with the escape key, and also possibly being able to close the window by clicking on the background space.
Fits the aesthetic very well! Wondering if we should use a similar popup system for profile management, or if we should make a whole sperate directory. I recommend using Lorem Ipsum for placeholder text, just to ensure there are no issues with formatting for longer texts/paragraphs. If the suggestions Ciaranengelbrecht mentioned are not too hard to implement, it would be great to put them in before merging to main. Otherise, this looks fine to merge.
@DJRyLau I was thinking the settings/profile management should be its own page since you may need to do multiple things on that page instead of just reading instructions like this pop-up, also to make it distinct as a settings page normally is.
I'll also add these in a commit soon (when I get a second to change them):
Created a pop-up box that shows up when you click on the (i) icon in the top right, has a transition when it comes in and goes out. Also included a super basic skeleton of what we could include on the about page once we build more of the website.