DK22Pac / plugin-sdk

An SDK for developing ASI/CLEO plugins for GTA San Andreas, GTA Vice City and GTA III
zlib License
431 stars 114 forks source link

GPS example broken due to missing type on GetD3DDevice template function #175

Closed likeawindrammer closed 9 months ago

likeawindrammer commented 9 months ago

Related to #167 and #166 I get the same error building the GPS example with the use of GetD3DDevice https://github.com/DK22Pac/plugin-sdk/blob/master/examples/GPS/Main.cpp#L97

However I'm unsure what would be the preferred way of fixing this. One way would be to do like in that PR and add the type IDirect3DDevice9 at every use of GetD3DDevice. Or another way would be to add a default type in the definition of the template such that it becomes template<typename T = IDirect3DDevice9> here https://github.com/DK22Pac/plugin-sdk/blob/915abf273607cad933cea729365adf22729ae7e7/plugin_sa/game_sa/RenderWare.h#L30C1-L30C1

likeawindrammer commented 9 months ago

These and other errors in the examples were fixed with https://github.com/DK22Pac/plugin-sdk/commit/eb990b7e32b17107e9fd70166dbf8db33f40f12e. Thank you gennariarmando!