Numbers - Design Improvements - Githubissues

DK96-OS / MathTools

Mathematical Software Components. This library is actively maintained, and aims to stay updated. New feature proposals are welcome, but may not be included.

Apache License 2.0

2 stars 1 forks source link

Numbers - Design Improvements #61

Closed DK96-OS closed 2 years ago

DK96-OS commented 2 years ago

Improve Usability of Numbers Module:

Make Strict classes open, enable overriding their methods
Convert Kotlin object methods to Java static methods

Redesign Prime Number Caches:

Remove private prime cache from PrimeNumberTools, use functional dependency injection to supply cache
Simplify Cache implementations

Resolves #58 Resolves #44

DK96-OS commented 2 years ago

Assumptions that were previously valid need to be checked. It is now more likely that an error will appear, particularly in the case where a BytePrimeCache is passed as an argument.

DK96-OS commented 2 years ago

Existing PrimeNumberTools test cases do not check large inputs that may expose errors related to cache size.

DK96-OS commented 2 years ago

Numbers Format package updates should have been added to a different branch, and different PR. These aren't behavioral changes, but will simplify usage in Java (so does improve flexibility).

DK96-OS commented 2 years ago

Maybe PrimeNumberTools can be renamed to Primes or PrimeTools or Prime.

There are many functions requiring use of prime numbers, so there are likely naturally forming groups that can use Prime as a prefix.

DK96-OS commented 2 years ago

Prime redesign should have been done on another PR. Now, it is blocking the other updates from being part of the release.

DK96-OS commented 2 years ago

This branch will be split into primes and non-primes updates, and this PR will be closed.