Increase Coverage Minimum to 92% - Githubissues

DK96-OS / MathTools

Mathematical Software Components. This library is actively maintained, and aims to stay updated. New feature proposals are welcome, but may not be included.

Apache License 2.0

2 stars 1 forks source link

Increase Coverage Minimum to 92% #72

Closed DK96-OS closed 2 years ago

DK96-OS commented 2 years ago

Increase the minimum coverage in all modules to at least 95% Instructions, and 92% Branches.

DK96-OS commented 2 years ago

Now coverage reports should be generated, and the verification check performed.

DK96-OS commented 2 years ago

strategy is not supported by any job that calls a Reusable Workflow. If the reusable workflows themselves cannot use strategy, then we'll be using Java 11 only.

DK96-OS commented 2 years ago

Problems remaining:

[x] Test Reports are not available for upload.
[x] Cache needs to be applied in all jobs

DK96-OS commented 2 years ago

The coverage verification is supposed to fail because the minimum has been increased.

DK96-OS commented 2 years ago

The test report upload issue would be resolved if generators module were ready to merge.

DK96-OS commented 2 years ago

Now that #63 has been merged, the generators module is available in the base branch. The generators module is the highest in the dependency graph, and contains the test-aggregator plugin, so the test report upload problem should be fixed after merging the latest changes from the base branch.

DK96-OS commented 2 years ago

The method java.util.List.of that provides immutable lists, was added in Java 9.

This is why the recent test failed when adding Java 8 to the testing matrix.

This error did not occur when changing the targetCompatibility in the build scripts. Only when the project is built using Java 8 does the error appear.

This means it is possible that if the Jar is built with JDK 11 targeting JRE 8, there won't be any issues running on JVM 8.

DK96-OS commented 2 years ago

This PR contains significant workflow developments that would be ideal to have available in all other branches.

The failing verify-coverage check is known, and expected due to the increase of minimum coverage parameters. This is being done to encourage progress at a reasonable pace.

Most modules will need work to reach coverage, excluding generators which was recently created. And each of these modules deserves independent and focused attention.

With all of these considerations being expressed, it is clearly the correct choice to merge this PR with this one failing check.

DK96-OS commented 2 years ago

Also, since build_and_test was removed, the badge in the ReadMe file needs to be updated.

DK96-OS commented 2 years ago

It appears that a workflow badge is only given to workflow files that run on events other than a reusable workflow_call.