search

DKerp / get-size

Determine the size in bytes an object occupies inside RAM.
MIT License
22 stars 12 forks source link

`impl GetSize` for external crate, behind a feature flag in this crate? #16

Open amandasaurus opened 9 months ago

amandasaurus commented 9 months ago

If I submitted a patch, which implemented GetSize for an external crate behind a feature flag, would you be willing to merge it?

smallvec is a library for storing small vectors inline, which saves memory. I tried to implement GetSize for this crate (behind a feature flag in this PR), but there is a bug, where get_size_derive was included twice and caused a cycle.

I do not fully understand Cargo dependency management good enough to fully understand what's going on here.

If I submitted a patch, which implemented impl GetSize for SmallVec, behind a smallvec feature flag, would you be willing to merge it? This is a suggestion from the smallvec author.