Issue#281 - Githubissues

DLFMetadataAssessment / Sandbox

Sandbox for reworked DLF AIG MWG Site / Output

MIT License

3 stars 10 forks source link

Issue#281 #289

Closed kateefly closed 2 years ago

kateefly commented 2 years ago

Covers both issue#281 and #284 .

kateefly commented 2 years ago

Hi @akhtars - could you review? If you're not able to, please let me know and I'll assign to someone else. This is a bit time sensitive as well since we're getting things ready for DLF Forum

akhtars commented 2 years ago

Yes, I can review by the end of the day, thanks. Sorry for the delay.

kateefly commented 2 years ago

I should have been more clear about the time sensitivity! Thank you @akhtars and please let me know if you need anything from me

akhtars commented 2 years ago

The changes look good and can be merged. Thought I'd check with @kateefly about two minor things I observed reviewing the Contributors page, neither of which were introduced by this edit:

Under "Leadership", should "who lead working during 2022" be changed to "who led working during 2022", or is it intended to be present tense?
Are "Ryan Mendenhall (2017)" and "Timothy Ryan Mendenhall (2016)" the same individual?

Happy to merge these commits as-is and if either of the above warrants further changes I can open another issue?

kateefly commented 2 years ago

Thanks for the catch on the present tense issue! I've fixed it and it should read better now.

As for whether or not that is the same person, I honestly have no idea! We gave people space for feedback and no one spoke up to confirm that or not. Since it's been a while, I think it's ok to leave them as is for now.

akhtars commented 2 years ago

Thanks!