DLMousey / OIDC.Core

Toy OAuth + OIDC provider written in .net core
1 stars 0 forks source link

RNGCryptoServiceProvider is obsolete #15

Open DLMousey opened 2 years ago

DLMousey commented 2 years ago

Getting build warnings where there's usage of the RNGCryptoServiceProvider.

this only seems to be in the RandomValueService at the minute so should be safe to swap out seems to be done manually in a couple of different places but only appears to be 3 or 4 classes doing this so should be safe to swap out, should probably abstract these into the RandomValueService so the randomness implementation being used is system wide.

Before it's swapped write some tests that assert the length of random values is correct and ideally some way of measuring the entropy?

Buiild warnings can be found on the annotations on the CI runs https://github.com/DLMousey/OIDC.Core/actions/runs/2899169966