search

DLR-AE / CampbellViewer

Unified plotting tool for Campbell diagrams, processing results of wind turbine simulation tools HAWCStab2 and Bladed
Apache License 2.0
2 stars 1 forks source link

style: Redo changes #22 #27

Closed njoeres closed 1 year ago

njoeres commented 2 years ago

I did some restructuring of the code, but I'm not completely happy with it, e.g., I put globals into a settings folder, but it's not only settings, but also related to the database.
So this can be seen as a first draft and is up for discussion.

hendrikverdonck commented 1 year ago

In general I really like the restructuring.

Comments: 1) I think model.py does not belong in data_storage, but should rather be on the top level. It would also be better to rename it to something a bit more specific, right? Something like tree_model.py or datatree_model.py. 2) I agree that it is not optimal now with the global definitions in settings.view. Fyi, the top comment of this post is what I based the implementation on (https://stackoverflow.com/questions/13034496/using-global-variables-between-files). Maybe we could add a very short module settings.globals which just contains the definition of the global variables.