search

DLR-AMR / t8code_JOSS

JOSS Paper about t8code
MIT License
0 stars 2 forks source link

Summary does not introduce AMR #10

Closed jwallwork23 closed 1 month ago

jwallwork23 commented 3 months ago

The "Summary" section does not say what mesh adaptation / AMR actually does, i.e., vary resolution to reduce approximation errors "where they matter" and reduce computational costs elsewhere. This is mentioned in the "Statement of Need" section but - given the summary is meant to be for a non-specialist audience - it would be good to have a sentence explaining this. Perhaps the introductory sentence could just be moved from the "Statement of Need" section to the "Summary".

(Part of JOSS review https://github.com/openjournals/joss-reviews/issues/6887.)

jmark commented 2 months ago

I added a sentence to the summary section.

jwallwork23 commented 1 month ago

Thanks for this. I'm happy for this issue to be closed.