search

DLR-RM / rl-baselines3-zoo

A training framework for Stable Baselines3 reinforcement learning agents, with hyperparameter optimization and pre-trained agents included.
https://rl-baselines3-zoo.readthedocs.io
MIT License
1.9k stars 495 forks source link

[Feature Request] Outdated dockerfile #391

Closed VineetTambe closed 10 months ago

VineetTambe commented 11 months ago

🚀 Feature

Hey,

I was trying to use the docker setup in the stablebaselines3 docker setup. But it seems to be really outdated in terms of the base image version?

Motivation

In addition to it being outdated. I am kind of confused as to why a run_gpu.sh and run_cpu.sh scripts are used as opposed to a docker compose? Which is a much cleaner way of doing the same?

Pitch

I went ahead and created an up to date dockerfile with gpu support with stable-baselines3==2.0.0a13. It has docker-compose support as well. Should I go ahead and raise a PR for it?

Alternatives

No response

Additional context

No response

Checklist

araffin commented 11 months ago

Hello,

I was trying to use the docker setup in the stablebaselines3 docker setup. But it seems to be really outdated in terms of the base image version?

Are you talking about the dockerfile or the image found on dockerhub?

The dockerfile should be up to date (I moved to micromamba recently), but because of new docker restrictions, I wasn't motivated to keep dockerhub versions up to date...

VineetTambe commented 11 months ago

Hey @araffin ,

I was talking about the image found on the dockerhub as the dockerfile pulls that image and a bunch of packages in the base image are outdated.