Closed jak3122 closed 3 months ago
It's weird because I see you've pushed a fix to my comment on your branch, but I can't see it on the PR page. First time I've seen that.
For around a day the PR page said it was processing something. Currently it says "1 workflow awaiting approval". I did forget to use the -u flag when pushing the branch originally, and only used it for the new commit, so I wonder if that broke something. I'll try pushing a dummy commit.
Alright now I see the fix commit on the PR page, hope that fixed it!
LGTM, thanks @jak3122! You can add you id to the name of all the contributors (see bottom of changelog)
Description
Changed the conditional when loading the
policy_kwargs
to handle the case where the savednet_arch
isNone
, simplified the code a bit, and added a test.Motivation and Context
I ran into this issue when using a wrapper script that potentially passes
None
to thenet_arch
parameter, and then when I go to load the saved model, there is an error.closes #1928
Types of changes
Checklist
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line