search

DLR-RY / TwoPhaseFlow

GNU General Public License v3.0
77 stars 38 forks source link

of2206 port #39

Open tmaric opened 1 year ago

tmaric commented 1 year ago
  1. Merged of2112 with master.
  2. Updated for OpenFOAM-v2206.

Suggestion: best if it is merged with a new branch of2206 and checked, port is work in progress.

HenningScheufler commented 1 year ago

Thanks for the pull request could you update the CI to of2206

tmaric commented 1 year ago

Sure, I'll give it a go

tmaric commented 1 year ago

There are multiple failures, you can check them up in my fork or I can submit a new merge request.

Most of the errors are missing&wrong keywords in the test case setup and there are errors in duplicate entries in the RTS tables . The problem is, TwoPhaseFlow duplicates the structure in VoF in OpenFOAM - the way around this would be to wclean VoF in OpenFOAM before compiling TwoPhaseFlow.

I can add the wclean into the workflow, but what do we do about the key errors? I won't have much time to deal with this in the next two weeks.

HenningScheufler commented 1 year ago

the branch of2206 works and all test pass.

the main issue was that the wrong header of zoneDistribute was used.