search

DLR-RY / TwoPhaseFlow

GNU General Public License v3.0
77 stars 38 forks source link

Mass source term model is working incorrectly for condensation #47

Open Johannes-Kind opened 1 year ago

Johannes-Kind commented 1 year ago

https://github.com/DLR-RY/TwoPhaseFlow/blob/fefa227a26f0774ce5715e27ff341133e3841c62/src/phaseChange/phaseChangeModels/massSourceTermModel/hardtWondra/hardtWondra.C#L148-L155

https://github.com/DLR-RY/TwoPhaseFlow/blob/fefa227a26f0774ce5715e27ff341133e3841c62/src/phaseChange/phaseChangeModels/massSourceTermModel/hardtWondraGasPhase/hardtWondraGasPhase.C#L149-L156

In both Hardt & Wondra models for phase change (see above), the scaling of the smeared mass source terms is not activated, if the total mass source is smaller than 1e-99 (i.e., if condensation occurs). The code should be changed to 

if (mag(intPsiLiquid.value()) > 1e-99)
{
    Nl = intPsi0/intPsiLiquid;
}
if (mag(intPsiVapor.value()) > 1e-99)
{
    Nv = intPsi0/intPsiVapor;
}

Now both evaporation and condensation can be modeled, even simultaneously in one system.