DLR-SC / ESID

This is the repository to the ESID frontend for visualization of infectious disease propagation.
Apache License 2.0
15 stars 3 forks source link

:beetle: Fix the initial translation of 'germany' in the search bar. #248

Closed JonasGilg closed 1 year ago

JonasGilg commented 1 year ago

Description

When first loading the website the name of 'germany' in the search bar was not translated, because the default state of the store was initialized before translations were available. This PR fixes that.

Design Decisions

A new component was added, that initializes state at the very top level. It now checks, if the translation for the district is missing.

Checklist

I, the author of this PR checked the following requirements for good software quality:

I, the reviewer checked the following things:

github-actions[bot] commented 1 year ago

Unit Test Results

  1 files  ±0  13 suites  ±0   23s :stopwatch: -4s 34 tests ±0  34 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  35 runs  ±0  35 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 03f1e199. ± Comparison against base commit a6438f2d.

:recycle: This comment has been updated with latest results.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5079008029


Changes Missing Coverage Covered Lines Changed/Added Lines %
frontend/src/App.tsx 0 11 0.0%
<!-- Total: 0 11 0.0% -->
Files with Coverage Reduction New Missed Lines %
frontend/src/util/i18n.ts 8 0%
<!-- Total: 8 -->
Totals Coverage Status
Change from base Build 5070838786: -0.6%
Covered Lines: 264
Relevant Lines: 1250

💛 - Coveralls