DLR-SC / ESID

This is the repository to the ESID frontend for visualization of infectious disease propagation.
Apache License 2.0
15 stars 3 forks source link

Upgrade line chart to amCharts 5 #277

Closed NXXR closed 11 months ago

NXXR commented 1 year ago

Description

This PR updates the line chart to use amCharts 5.

Related Issues

Performance & Quality

Checklist

I, the author of this PR checked the following requirements for good software quality:

I, the reviewer checked the following things:

github-actions[bot] commented 1 year ago

Unit Test Results

  1 files  ±0  14 suites  ±0   33s :stopwatch: +9s 32 tests ±0  32 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  33 runs  ±0  33 :heavy_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 694ab8f8. ± Comparison against base commit c7b98ae1.

:recycle: This comment has been updated with latest results.

JonasGilg commented 1 year ago

Can you make the date selection a single click again?

NXXR commented 1 year ago

Can you make the date selection a single click again?

sorry, forgot yesterday. is fixed now.

NXXR commented 1 year ago

Feels much better now. Sadly I discovered another issue. If you toggle a scenario or group filters the time selector goes missing :(

looking into it. It seems to only happen when you activate/deactivate the first scenario or group filters, but not with the second scenario. Can you confirm that?

JonasGilg commented 1 year ago

It seems to only happen when you activate/deactivate the first scenario or group filters, but not with the second scenario. Can you confirm that?

Also happens with other scenarios/filters and when reloading the page.

NXXR commented 12 months ago

guide dissapperaing (#252 ) should be fixed now