DLR-SC / ESID

This is the repository to the ESID frontend for visualization of infectious disease propagation.
Apache License 2.0
17 stars 3 forks source link

feature/parameter-units #356

Closed JonasGilg closed 5 months ago

JonasGilg commented 5 months ago

Description

Adds units to the parameter view and sets a new ESID release in the changelog.

Design Decisions

This hardcodes the units in the translation file. There is also logic to transform numbers with percent to be shown as percentages instead of normalized.

Checklist

I, the author of this PR checked the following requirements for good software quality:

I, the reviewer checked the following things:

github-actions[bot] commented 5 months ago

Test Results

39 tests  ±0   39 :white_check_mark: ±0   11s :stopwatch: ±0s 17 suites ±0    0 :zzz: ±0   1 files   ±0    0 :x: ±0 

Results for commit b67e68ec. ± Comparison against base commit 8058185d.

:recycle: This comment has been updated with latest results.

NXXR commented 5 months ago

How feasible is it to add a spanning parent cell in the header that has the category name (i.e. "Alter"/"Age")? It could help users understand the differenty columns quicker.

decided to be moved to a separate issue