search

DLR-SC / corpus-annotation-graph-builder

Corpus Annotation Graph builder (CAG) is an architectural framework that employs the build-and-annotate pattern for creating a graph.
MIT License
10 stars 1 forks source link

Constant NODE and Edge NAMES definitions partially incorrect #7

Closed muelldlr closed 1 year ago

muelldlr commented 1 year ago

As defined in GraphCreatorBase the name of the Node needs to be _ABSTRACT_NODE_NAME = 'Abstract'. But in nodes.py it is defined as AbstractNode.

The solution is to rename class AbstractNode(GenericOOSNode): to class Abstract(GenericOOSNode):

Edit: Same applies to _EDGE_ABSTRACT_TEXT = 'AbstractText'. This edge is not defined in relations.py

Or do you see any negative side effect by renaming this class @roxanneelbaff ?

roxanneelbaff commented 1 year ago

Change the name in the base instead of the class name

roxanneelbaff commented 1 year ago

For the edge the name of misleading please add edge at the end of its name and define it in the relations