search

DLR-SC / tigl

The TiGL Geometry Library to process aircraft geometries in pre-design.
https://dlr-sc.github.io/tigl/
Apache License 2.0
231 stars 60 forks source link

Fix bug causing wrong rotor rotation in y direction (fixes #870) #1000

Closed svengoldberg closed 4 months ago

svengoldberg commented 4 months ago

Fix issue #870: Wrong if clause condition caused misinterpretation of the sign and caused wrong rotation in decompose routine

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.97%. Comparing base (ede4575) to head (8bacc38).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/DLR-SC/tigl/pull/1000/graphs/tree.svg?width=650&height=150&src=pr&token=8b0i0TsOw6&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DLR-SC)](https://app.codecov.io/gh/DLR-SC/tigl/pull/1000?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DLR-SC) ```diff @@ Coverage Diff @@ ## master #1000 +/- ## ========================================== + Coverage 68.95% 68.97% +0.02% ========================================== Files 299 299 Lines 26499 26499 ========================================== + Hits 18272 18278 +6 + Misses 8227 8221 -6 ``` | [Files](https://app.codecov.io/gh/DLR-SC/tigl/pull/1000?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DLR-SC) | Coverage Δ | | |---|---|---| | [src/geometry/CTiglTransformation.cpp](https://app.codecov.io/gh/DLR-SC/tigl/pull/1000?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DLR-SC#diff-c3JjL2dlb21ldHJ5L0NUaWdsVHJhbnNmb3JtYXRpb24uY3Bw) | `80.47% <100.00%> (+2.02%)` | :arrow_up: |