Closed joergbrech closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.81%. Comparing base (
42935bb
) to head (b0d726f
). Report is 6 commits behind head on master.
@MarAlder: Because you were interested: With this PR, tigl still uses the boost version distributed in the thirdparty subdir, but:
TIGL_USE_INTERNAL_BOOST
to false and installing boost some other way, e.g. using conda.Nice! I just like it when a repo works with as few third-party software copies as possible. Having both options is of course a nice solution as well. Building boost in particular is always a bit tricky...
Fixes #1006
Updated action versions to update Node.js
The updated codecov action now needs a token to upload coverage reports. This has been added. Also I needed to add some arguments to the codecov action so that both unit and integration tests are picked up.
Needed to downgrade macos version, because the latest runner updated to the new arm architecture which is not supported by our build system yet (another To-Do for us)
Needed to update boost and gradle to build on macos. The update of gradle auto-changed some of the files in the bindings/java directory.
The update of boost had a dependency conflict with qt, so I needed to update qt
In addition, I now got a weird ninja error on all platforms:
ninja: error: build.ninja:6801: multiple outputs aren't (yet?) supported by depslog; bring this up on the mailing list if it affects you
. So I updated ninjaThe newer Qt Version distributed with Anaconda was apparently build with gcc>9, which resulted in a GLIBC and GLIBCXX conflict on the Ubuntu 20.04 runner that only has g++ 9.3 installed. To save myself the trouble, I just removed ubuntu-20.04 from the build matrix. As of now, ubuntu-latest and ubuntu-22.04 are the same, but I suppose github will soon switch ubuntu-latest to ubuntu-24.04 and then we will be testing two different linux configs again.