DLR-SC / tigl

The TiGL Geometry Library to process aircraft geometries in pre-design.
https://dlr-sc.github.io/tigl/
Apache License 2.0
241 stars 61 forks source link

Usage of symmetry attributes #844

Open MarAlder opened 3 years ago

MarAlder commented 3 years ago

Hi,

I'm working up some examples to enrich the CPACS docs (https://github.com/DLR-SL/CPACS/issues/733, https://github.com/DLR-SL/CPACS/issues/735) with some more detailed descriptions on the current symmetry concepts. In this context, I just want to make sure that I understand the current concept and implementation in TiGL correctly.

I have two questions:

element symmetry attribute

nacelle.zip

I noticed that <enginePylon uID="pylon" symmetry="none"> prevents the inheritance of symmetry as expected:

<wings>
    <wing uID="wing" symmetry="x-z-plane">
    ...
</wings>
<enginePylons>
    <enginePylon uID="pylon" symmetry="none">
        <parentUID>wing</parentUID>
        ...
    </enginePylon>
</enginePylons>
<engines>
    <engine uID="aircraft_engine">
        <name>aircraft_engine</name>
        <engineUID>engine</engineUID>
        <parentUID>pylon</parentUID>
        ...
    </engine>
</engines>

case1

However, applying symmetry="none" to the engine itself does not work:

<wings>
    <wing uID="wing" symmetry="x-z-plane">
    ...
</wings>

<enginePylons>
    <enginePylon uID="pylon">
        <parentUID>wing</parentUID>
        ...
    </enginePylon>
</enginePylons>
<engines>
    <engine uID="aircraft_engine" symmetry="none">
        <name>aircraft_engine</name>
        <engineUID>engine</engineUID>
        <parentUID>pylon</parentUID>
        ...
    </engine>
</engines>

case2

Is this a TiGL bug or a misunderstanding on my side?

parentUID symmetry attribute

The concept of choosing only a particular side of the symmetry when referencing (see Sec. 8 of the CPACS docs) via symmetry="def" "symm" and "full" is just not implemented in TiGL, is it?

grafik (figure modified with paint 😏)

rainman110 commented 3 years ago

Hi @MarAlder . First, kudos for a great overhauling of the cpacs docs. Is this definetely a huge improvement.

This is probably a TiGL issue. I think we never evaluated the symmetry attribute but only the symmetry plane.

I'll have a look into it.