search

DLR-SC / tigl

The TiGL Geometry Library to process aircraft geometries in pre-design.
https://dlr-sc.github.io/tigl/
Apache License 2.0
235 stars 60 forks source link

wing guide curve points x-direction does not respect wing transformation #975

Closed merakulix closed 10 months ago

merakulix commented 10 months ago

As a consequence the x and z coordinates of wing guide curve points are wrong if the wing coordinate system is rotated.

In the following line, the global x-direction is used:

https://github.com/DLR-SC/tigl/blob/bd9dca3dac00a41a6e4d6721dc9659053a43b6b4/src/wing/CTiglWingSegmentGuidecurveBuilder.cpp#L102

Here we should apply the wing transformation.

To reproduce: Open simple_test_guide_curves.xml and rotate the wing. This changes the shape of the wing:

Before rotation of the wing: before

After rotation of the wing: after