DLR-SC / tigl

The TiGL Geometry Library to process aircraft geometries in pre-design.
https://dlr-sc.github.io/tigl/
Apache License 2.0
231 stars 60 forks source link

Fix #975: Transform rX-Direction of guide curve with wing coordinate system #976

Closed merakulix closed 8 months ago

merakulix commented 8 months ago

Description

Now the rX-Direction respects the wing coorddinate system

How Has This Been Tested?

Visual confirmation in TiGL Viewer and new unit test

Screenshots, that help to understand the changes(if applicable):

Checklist:

codecov-commenter commented 8 months ago

Codecov Report

Merging #976 (f8f027e) into master (5f3e172) will increase coverage by 0.15%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/DLR-SC/tigl/pull/976/graphs/tree.svg?width=650&height=150&src=pr&token=8b0i0TsOw6&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DLR-SC)](https://app.codecov.io/gh/DLR-SC/tigl/pull/976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DLR-SC) ```diff @@ Coverage Diff @@ ## master #976 +/- ## ========================================== + Coverage 68.75% 68.90% +0.15% ========================================== Files 298 298 Lines 26479 26479 ========================================== + Hits 18206 18246 +40 + Misses 8273 8233 -40 ``` | [Files](https://app.codecov.io/gh/DLR-SC/tigl/pull/976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DLR-SC) | Coverage Δ | | |---|---|---| | [src/wing/CTiglWingSegmentGuidecurveBuilder.cpp](https://app.codecov.io/gh/DLR-SC/tigl/pull/976?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DLR-SC#diff-c3JjL3dpbmcvQ1RpZ2xXaW5nU2VnbWVudEd1aWRlY3VydmVCdWlsZGVyLmNwcA==) | `88.88% <100.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/DLR-SC/tigl/pull/976/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=DLR-SC)