DLR-SL / CPACS

CPACS - Common Parametric Aircraft Configuration Schema
http://dlr-sl.github.io/CPACS/
Apache License 2.0
79 stars 38 forks source link

RibsPositioning using EtaXsiPoint #670

Closed GodertdeZoetenGKNFokker closed 2 years ago

GodertdeZoetenGKNFokker commented 3 years ago

When using the ribsPositioning option startEtaXsiPoint and endEtaXsiPoint, I was wondering what should be done when these points are not on the ribStart or ribEnd curve? Should the rib just pass through this defined point and be trimmed at the LE/TE or a spar?

Also: what should be done with the locations of the ribs between the start and the end?

Finally: I noticed that in the CPACS 3.0 documentation ribsPositioning does not have a ribReference, but in CPACS 2.3.1 and CPACS 3.0 documentation it does have a ribReference. Also, my example CPACS 3.0 files does have a ribReference. Hence my question: maybe ribReference was accidentally omitted in the CPACS 3.0 documentation?

Kind regards, Godert

MarAlder commented 3 years ago

Hi Godert,

to your last comment: yes, the ribReference was accidentally omitted in CPACS 3.0. See this commit. However, TiGL 3 needs this parameter. It has been added in CPACS 3.1.

RibStart and RibEnd limit the shape extrusion and startEtaXsiPoint and endEtaXsiPoint are control points defining the beginning and ending of the rib set and thus must not be on the start- or end curve. (@rainman110 or @joergbrech can you confirm this?).

We should update this figure, but I guess it shows that start and end point must not be on the ribStart or ribEndCurve: grafik