Closed MarAlder closed 3 years ago
Hi @MarAlder, looks good and makes the structure much more clear! I am very happy with the creation and application of the common nomenclature as well as with the more harmonized common structure of analysis node contents .
One thing to consider to further harmonize the <analysis>
node contents:
"The second part contains the actual analysis data and its name may depending on the discipline (myResults used as a placeholder)."
for myResults we now have:
<aeroCase>
-> <aeroData>
<flightLoadCase>, <groundLoadCase>, <crashLoadCase>
-> <loads>
<aeroMap>
-> <aeroPerformanceMap>, <aeroLimitsMap>
should we provide a hint on naming conventions for the myData node? We can distinguish two kinds of result nodes: data and maps. Then we could have the following:
<aeroCase>
-> <aeroData>
<flightLoadCase>, <groundLoadCase>, <crashLoadCase>
-> <loadData>
<aeroMap>
-> <aeroPerformanceMap>, <aeroLimitsMap>
i.e.: the xxxData and xxxMap represent the base nodes for the actual analysis data. This convention could be used throughout the complete <analysis>
node
Good suggestion!
Implemented via e485289 (see development.md)
No feedback; so I assume everything is harmonic now :)
With regard to the CPACS 3.3 release, some larger adjustments and enhancements such as
aeroCases
,loadCases
andmissionDefinitions
orpointPerformances
were discussed. During and after the stakeholder meetings there were some requests to harmonize the nomenclature before the official finalization. This issue will summarize the major changes:Naming conventions:
I added the proposed development guidelines (#704) to development.md. The proposed naming conventions are applied in a common structure for analysis elements:
The naming conventions and harmonization of analysis elements will affect the following implementations:
aeroCases
before:
after:
flight/groundLoadCases
before:
after:
aeroMaps (will not be part of CPACS 3.3!)
We also propose to harmonize the
aeroMaps
in a future release:now:
future:
Summary of analyses nodes
So I would say it looks really harmonic:
missionDefinitions
before:
after:
pointPerformances
before:
after: