DLR-SL / CPACS

CPACS - Common Parametric Aircraft Configuration Schema
http://dlr-sl.github.io/CPACS/
Apache License 2.0
78 stars 38 forks source link

profileGeometryType vs. profileGeometry2DType #782

Open jnwalther opened 2 years ago

jnwalther commented 2 years ago

As mentioned in #780, there seem to be some things, that need clarification w.r.t. profileGeometryType and profileGeometry2DType and what exactly is the purpose for each.

Let's take a look at the current situation: The profileGeometryType is currently being used by fuselageProfile, rotorAirfoil and wingAirfoil. Historically it provides a pointList of curvePointListXYZType, i.e. a list of 3D points. As far as I am aware, one of the dimensions is always filled with zeroes. Thus we have in fact always a 2D profile, which is only given in 3D in order to allow for unambiguous 3D transformations down the line. However, more recently, we have also added the cst2D and standardProfiles nodes, which only provide parameters to describe a profile in 2D. As such, there is no way to tell how the profile is aligned in 3D, which undermines the whole point of having a 3D point list as stated previously.

To make matters worse, there is an additional profileGeometry2DType, referenced by curveProfile and nacelleProfile, which once again provides a pointList node, this time of pointListXYVectorType. We also have the cst2D node once more, which references the cst2DType (exactly like in profileGeometry). The standardProfiles node is missing.

This is both confusing and inconsistent, so we should consider the following changes:

@MarAlder, @joergbrech, @antonreiswich, @rainman110, @CLiersch, @ChristianHesse, please let me know what you think.

jnwalther commented 2 years ago

Here is a diagram of an updated profileGeometryType definition for illustration:

profile_geometry_node